Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added abstraction layer for boundary condition application and stepper initialization, and the capability to add profiles to boundary conditions #86

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added abstraction layer for boundary condition application and stepper initialization, and the capability to add profiles to boundary conditions #86

wants to merge 1 commit into from
+626 −309

Conversation

mehdiataei
Copy link
Contributor

@mehdiataei mehdiataei commented Oct 31, 2024 •
edited
Loading

Contributing Guidelines

Description

  • Added abstraction layer for boundary condition efficient encoding/decoding of auxiliary data
  • Added the capability to add profiles to boundary conditions
  • Added abstraction layer to initialize fields and BCs inside stepper (Optionally called)
  • Fixes Non-uniform boundary velocity profile #74

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • All pytest tests pass

Linting and Code Formatting

Make sure the code follows the project's linting and formatting standards. This project uses Ruff for linting.

To run Ruff, execute the following command from the root of the repository:

ruff check .
  • Ruff passes

@mehdiataei mehdiataei marked this pull request as ready for review October 31, 2024 16:56
@mehdiataei mehdiataei changed the title Profile inlet Added abstraction layer for boundary condition and the capability to add profiles to boundary conditions Oct 31, 2024
@mehdiataei mehdiataei force-pushed the profile_inlet branch 6 times, most recently from f0f81c3 to d07713d Compare November 4, 2024 01:39
hsalehipour
hsalehipour requested changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@hsalehipour hsalehipour left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. This is very helpful. I have made some comments which I think will improve this work.

examples/cfd/flow_past_sphere_3d.py Show resolved Hide resolved
examples/cfd/flow_past_sphere_3d.py Outdated Show resolved Hide resolved
examples/cfd/windtunnel_3d.py Show resolved Hide resolved
xlb/operator/boundary_condition/bc_regularized.py Show resolved Hide resolved
xlb/operator/boundary_condition/bc_zouhe.py Outdated Show resolved Hide resolved
xlb/operator/boundary_condition/bc_zouhe.py Outdated Show resolved Hide resolved
examples/cfd/windtunnel_3d.py Outdated Show resolved Hide resolved
examples/cfd/flow_past_sphere_3d.py Outdated Show resolved Hide resolved
examples/cfd/lid_driven_cavity_2d.py Outdated Show resolved Hide resolved
xlb/operator/boundary_condition/bc_extrapolation_outflow.py Show resolved Hide resolved
@mehdiataei
Copy link
Contributor Author

Thanks for the PR. This is very helpful. I have made some comments which I think will improve this work.

Thanks for the comments. I'll take a look.

@autodesk-chorus
Copy link

Chorus detected one or more security issues with this pull request. See the Checks tab for more details.

As a reminder, please follow the secure code review process as part of the Secure Coding Non-Negotiable requirement.

@mehdiataei mehdiataei changed the title Added abstraction layer for boundary condition and the capability to add profiles to boundary conditions Added abstraction layer for boundary condition aux data and implementaiton, and the capability to add profiles to boundary conditions Nov 28, 2024
@mehdiataei mehdiataei force-pushed the profile_inlet branch 3 times, most recently from c954e93 to 49cb066 Compare November 28, 2024 22:47
@mehdiataei mehdiataei requested review from hsalehipour and removed request for massimim November 28, 2024 22:51
hsalehipour
hsalehipour requested changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@hsalehipour hsalehipour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improved PR. I have left lots of commetns (major revisions). Please apply the changes and ping me again to review. I am happy to add these changes directly myself if you prefer. Thank you.

examples/cfd/flow_past_sphere_3d.py Outdated Show resolved Hide resolved
examples/cfd/flow_past_sphere_3d.py Show resolved Hide resolved
examples/cfd/flow_past_sphere_3d.py Outdated Show resolved Hide resolved
examples/cfd/flow_past_sphere_3d.py Show resolved Hide resolved
examples/cfd/lid_driven_cavity_2d.py Show resolved Hide resolved
xlb/operator/boundary_condition/bc_zouhe.py Outdated Show resolved Hide resolved
xlb/operator/boundary_condition/bc_zouhe.py Show resolved Hide resolved
xlb/operator/boundary_condition/bc_regularized.py Show resolved Hide resolved
xlb/operator/boundary_condition/bc_regularized.py Outdated Show resolved Hide resolved
xlb/operator/boundary_masker/mesh_boundary_masker.py Show resolved Hide resolved
@mehdiataei mehdiataei changed the title Added abstraction layer for boundary condition aux data and implementaiton, and the capability to add profiles to boundary conditions Added abstraction layer for boundary condition application and stepper initialization, and the capability to add profiles to boundary conditions. Nov 30, 2024
@mehdiataei mehdiataei force-pushed the profile_inlet branch 2 times, most recently from 530e82d to 53f626c Compare November 30, 2024 01:35
@mehdiataei mehdiataei changed the title Added abstraction layer for boundary condition application and stepper initialization, and the capability to add profiles to boundary conditions. Added abstraction layer for boundary condition application and stepper initialization, and the capability to add profiles to boundary conditions Nov 30, 2024
@mehdiataei
Added abstraction layer for boundary condition application and steppe…
c3cd0c1 
…r initialization, and the capability to add profiles to boundary conditions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsalehipour hsalehipour hsalehipour requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non-uniform boundary velocity profile
2 participants
@mehdiataei @hsalehipour